-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of API/user config controlled auto exposure and gain settings #43
base: master
Are you sure you want to change the base?
Conversation
6a0f318
to
e562d92
Compare
…fig - needs more testing
e562d92
to
ca70b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, everything sticks to the api and is well named. code looks good :)
- I tested the changes, haven't found an issue yet :) - so far it works well.
@ZanzyTHEbar I think I did, while the core functionality works as expected, changing the resolution causes the framebuffer to be a null pointer (or at least I think so, judging by the ESP_OK error which happens if we don't have the FB at the very beginning). I was in the process of inspecting the original examples buuuut decided to give a minute or two and focus on other projects to "reset" so to speak xD I'll be coming back to it today, if all goes according to plan |
This PR adds the ability to control the auto exposure, auto gain more easily, its levels, and the brightness of the video feed.
These settings can be changed in two ways:
ESP/ini/user_config.ini [autoexposure]
settingsetCamera
command